Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Add the logs tab to container views #184854

Merged
merged 3 commits into from
Jun 10, 2024
Merged

[Infra] Add the logs tab to container views #184854

merged 3 commits into from
Jun 10, 2024
+42 −3

Conversation

jennypavlova
Copy link
Member

Closes #184770

Summary

This PR adds the logs tab to container views.

Testing

  • Enable Container view from Infra settings
  • Go to Inventory and select Docker Containers from the "Show" drop-down
  • Click on a container
    • The logs tab should be visible
  • Click on the Logs tab
  • The search functionality and the link (with the filter) should work

image

  • Click on "Open as Page"
    • The logs tab should be visible
  • The search functionality and the link (with the filter) should work
image
Screen.Recording.2024-06-05.at.14.20.11.mov
  • ⚠️ If some of the containers on the edge cluster don't have logs in the logs settings the container.id can be added and used in inventory to find a container with logs ( This should be added for the docker containers on edge soon - for now it can be checked for a non-docker container )

image

Example with a container id (with logs)

image

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jun 5, 2024
@jennypavlova jennypavlova self-assigned this Jun 5, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova jennypavlova changed the title [Infra ]Add the logs tab to container views [Infra] Add the logs tab to container views Jun 5, 2024
@jennypavlova jennypavlova marked this pull request as ready for review June 6, 2024 09:07
@jennypavlova jennypavlova requested a review from a team as a code owner June 6, 2024 09:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 6, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 10, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.6MB 1.6MB +6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

crespocarlos
crespocarlos approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jennypavlova jennypavlova merged commit 2d3dc3f into elastic:main Jun 10, 2024
24 checks passed
@jennypavlova jennypavlova deleted the 184770-infra-add-logs-tab-to-container-views branch June 10, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra] Add Logs tab to container views
6 participants
@jennypavlova @apmmachine @elasticmachine @kibana-ci @crespocarlos @kibanamachine